Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:fix incorrect dir operations when create or load inverted index #38359

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix:fix incorrect dir operations when create or load inverted index #38359

merged 1 commit into from
Dec 17, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 10, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from 22f5d2a to e2b7bfc Compare December 10, 2024 15:32
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (9be106d) to head (0a0f48b).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/index/InvertedIndexTantivy.cpp 92.30% 1 Missing ⚠️
internal/core/src/segcore/load_index_c.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38359      +/-   ##
==========================================
+ Coverage   80.90%   80.93%   +0.02%     
==========================================
  Files        1376     1375       -1     
  Lines      192714   193655     +941     
==========================================
+ Hits       155915   156732     +817     
- Misses      31293    31395     +102     
- Partials     5506     5528      +22
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.98% <87.50%> (+0.05%) ⬆️
Go 83.03% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.h 53.84% <ø> (ø)
internal/core/src/storage/FileManager.h 59.57% <100.00%> (+1.79%) ⬆️
internal/core/src/index/InvertedIndexTantivy.cpp 92.64% <92.30%> (-0.13%) ⬇️
internal/core/src/segcore/load_index_c.cpp 34.32% <50.00%> (+0.10%) ⬆️

... and 175 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 11, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 11, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from e2b7bfc to dcaea1a Compare December 11, 2024 07:24
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from dcaea1a to e35e34e Compare December 11, 2024 09:06
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from e35e34e to 49293a6 Compare December 11, 2024 13:42
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 11, 2024
@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from 49293a6 to ada1014 Compare December 11, 2024 13:43
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from ada1014 to 9afaadc Compare December 12, 2024 03:23
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from 9afaadc to 7e6f9d5 Compare December 13, 2024 06:43
@sre-ci-robot sre-ci-robot removed the size/M Denotes a PR that changes 30-99 lines. label Dec 13, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Dec 13, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from 7e6f9d5 to c642431 Compare December 13, 2024 18:14
@czs007
Copy link
Collaborator

czs007 commented Dec 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhagnlu zhagnlu force-pushed the fix_inverted_dir_op branch from c642431 to 0a0f48b Compare December 17, 2024 02:02
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 17, 2024
@mergify mergify bot added the ci-passed label Dec 17, 2024
@czs007 czs007 added this to the 2.5.0 milestone Dec 17, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 17, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 9afcc5b into milvus-io:master Dec 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zhagnlu @czs007 @sre-ci-robot