Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add more info to local chunk manager log #38357

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Dec 10, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 10, 2024
Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 10, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (7ea9c98) to head (f7c8be5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/LocalChunkManager.cpp 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38357      +/-   ##
==========================================
+ Coverage   81.03%   81.05%   +0.01%     
==========================================
  Files        1373     1373              
  Lines      191695   191695              
==========================================
+ Hits       155340   155371      +31     
+ Misses      30840    30823      -17     
+ Partials     5515     5501      -14     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.83% <50.00%> (ø)
Go 83.16% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/storage/LocalChunkManager.cpp 68.75% <50.00%> (ø)

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 10, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9ef7697 into milvus-io:master Dec 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants