Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix bug for Search fails with filter expression contains underscore #38302

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 9, 2024

Enhance the matching for elements within the UnaryRangeArray
#38068

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 9, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 9, 2024
Copy link
Contributor

mergify bot commented Dec 9, 2024

@JsDove Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 9, 2024
Copy link
Contributor

mergify bot commented Dec 9, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Dec 10, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 10, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove JsDove force-pushed the 2.4-fix_array_match branch from 8942422 to a98042c Compare December 13, 2024 06:48
@mergify mergify bot added the ci-passed label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (1da4ac4) to head (b6f866b).
Report is 9 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/UnaryExpr.h 0.00% 9 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38302      +/-   ##
==========================================
- Coverage   79.50%   79.50%   -0.01%     
==========================================
  Files        1077     1077              
  Lines      169330   169341      +11     
==========================================
+ Hits       134633   134638       +5     
- Misses      30234    30244      +10     
+ Partials     4463     4459       -4     
Files with missing lines Coverage Δ
internal/core/src/exec/expression/UnaryExpr.cpp 87.14% <0.00%> (-0.42%) ⬇️
internal/core/src/exec/expression/UnaryExpr.h 73.49% <0.00%> (-8.94%) ⬇️

... and 19 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@JsDove
Copy link
Contributor Author

JsDove commented Dec 18, 2024

master pr: #38085

@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c24f666 into milvus-io:2.4 Dec 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants