Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sparse inc mast less than uint32 max #38250

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 5, 2024

relate: #35853

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 5, 2024
Copy link
Contributor

mergify bot commented Dec 5, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 5, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (18bef5e) to head (2401d30).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (18bef5e) and HEAD (2401d30). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (18bef5e) HEAD (2401d30)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38250       +/-   ##
===========================================
- Coverage   81.07%   68.85%   -12.23%     
===========================================
  Files        1372      289     -1083     
  Lines      191508    25508   -166000     
===========================================
- Hits       155268    17563   -137705     
+ Misses      30745     7945    -22800     
+ Partials     5495        0     -5495     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.85% <ø> (ø)
Go ∅ <ø> (∅)

see 1083 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 6, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 6, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 6, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Dec 6, 2024
@sre-ci-robot sre-ci-robot merged commit f16232f into milvus-io:master Dec 6, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants