Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix crash when enable standby and streaming #38239

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 5, 2024

issue: #38125

  • connect kv at standby mode.
  • make balancer initialization lazy.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (7944538) to head (60addad).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/server.go 86.36% 2 Missing and 1 partial ⚠️
internal/streamingcoord/server/server.go 50.00% 2 Missing and 1 partial ⚠️
...ternal/streamingcoord/server/service/assignment.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38239      +/-   ##
==========================================
- Coverage   81.09%   81.08%   -0.02%     
==========================================
  Files        1372     1372              
  Lines      191565   191582      +17     
==========================================
- Hits       155352   155335      -17     
- Misses      30719    30740      +21     
- Partials     5494     5507      +13     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.85% <ø> (ø)
Go 83.20% <75.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/streamingcoord/server/builder.go 100.00% <100.00%> (ø)
internal/datacoord/server.go 72.92% <86.36%> (-0.07%) ⬇️
internal/streamingcoord/server/server.go 78.78% <50.00%> (-8.72%) ⬇️
...ternal/streamingcoord/server/service/assignment.go 78.57% <40.00%> (-21.43%) ⬇️

... and 29 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 18bef5e into milvus-io:master Dec 6, 2024
18 of 20 checks passed
@chyezh chyezh deleted the fix_crash_when_enable_standby_and_streaming branch December 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants