Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Unify querycoord meta metrics #38233

Merged

Conversation

congqixia
Copy link
Contributor

Related to #36456

Unify collection/partition number metrics to collection manager in case of unwant missing modification

Related to milvus-io#36456

Unify collection/partition number metrics to collection manager in case
of unwant missing modification

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (af288a9) to head (4e5cb41).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38233       +/-   ##
===========================================
+ Coverage   68.85%   81.11%   +12.26%     
===========================================
  Files         289     1372     +1083     
  Lines       25508   191565   +166057     
===========================================
+ Hits        17563   155393   +137830     
- Misses       7945    30689    +22744     
- Partials        0     5483     +5483     
Components Coverage Δ
Client 74.43% <ø> (∅)
Core 68.85% <ø> (ø)
Go 83.24% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_release.go 81.51% <ø> (ø)
internal/querycoordv2/meta/collection_manager.go 86.68% <100.00%> (ø)

... and 1081 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 5, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 32645fc into milvus-io:master Dec 5, 2024
20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 5, 2024
Related to milvus-io#36456

Unify collection/partition number metrics to collection manager in case
of unwant missing modification

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Dec 5, 2024
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 6, 2024
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 6, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 6, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 6, 2024
Cherry pick from master
pr: #36471 #38233

related to: #36456

---------

Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Co-authored-by: sthuang <[email protected]>
@congqixia congqixia deleted the enhance/unify_qc_colpart_metrics branch December 10, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants