Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Reduce mutex contention in datacoord meta #38230

Open
wants to merge 5 commits into
base: 2.4
Choose a base branch
from
+150 −93

Merge branch '2.4' of github.com:milvus-io/milvus into 2412-opt-meta-…

7ee272c
Select commit
Loading
Failed to load commit list.
Open

enhance: [2.4] Reduce mutex contention in datacoord meta #38230

Merge branch '2.4' of github.com:milvus-io/milvus into 2412-opt-meta-…
7ee272c
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Dec 17, 2024 in 1s

5 rules match and 29 potential rules

Rule: Add needs-dco label when DCO check failed (comment, label)

  • -status-success=DCO
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

✅ Rule: Add dco-passed label when DCO check passed (label)

  • status-success=DCO
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

✅ Rule: Test passed for code changed on 2.* branch (label)

  • base~=^2(\.\d+){1,2}$
  • status-success=Code Checker AMD64 Ubuntu 22.04
  • status-success=Code Checker MacOS 13
  • status-success=cpu-e2e
  • any of:
    • status-success=Build and test AMD64 Ubuntu 22.04
    • status-success=Build and test AMD64 Ubuntu 20.04
  • any of:
    • status-success=UT for Cpp
    • status-success=cpp-unit-test
  • any of:
    • status-success=UT for Go
    • status-success=go-unit-test
  • any of:
    • status-success=Integration Test
    • status-success=integration-test

Rule: Test passed for tests changed (label)

  • -files~=^(?!tests\/python_client).+
  • status-success=cpu-e2e
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Test passed for docs changed only (label)

  • -files~=^(?!.*\.(md)).*$
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Test passed for non go or c++ code changed (label)

  • -files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • status-success=cpu-e2e
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Test passed for go unittest code changed-master (label)

  • any of:
    • -files~=^(?!client\/.*_test\.go).*$
    • -files~=^(?!internal\/.*_test\.go).*$
    • -files~=^(?!pkg\/.*_test\.go).*$
  • status-success=Code Checker AMD64 Ubuntu 22.04
  • status-success=Code Checker MacOS 13
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master
  • any of:
    • status-success=Build and test AMD64 Ubuntu 22.04
    • status-success=Build and test AMD64 Ubuntu 20.04
  • any of:
    • status-success=UT for Go
    • status-success=go-unit-test

Rule: Test passed for go unittest code changed -2.2.* (label)

  • -files~=^(?!internal\/.*_test\.go).*$
  • base~=^2(\.\d+){1,2}$
  • status-success=Code Checker AMD64 Ubuntu 22.04
  • status-success=Code Checker MacOS 13
  • any of:
    • status-success=Build and test AMD64 Ubuntu 22.04
    • status-success=Build and test AMD64 Ubuntu 20.04

Rule: Test passed for mergify changed (label)

  • -files~=^(?!\.github\/mergify\.yml).*$
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Test passed for title skip e2e (label)

  • -files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • title~=\[skip e2e\]
  • label=kind/enhancement
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Blocking PR if missing a related issue or doesn't have kind/enhancement label (comment, label)

  • all of:
    • -body~=https://github.com/milvus-io/milvus/issues/[0-9]{1,6}(\s+|$)
    • -body~=\#[0-9]{1,6}(\s+|$)
  • -label=kind/doc
  • -label=kind/test
  • -title~=\[automated\]
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master
  • any of:
    • all of:
      • label=kind/enhancement
      • any of:
        • label=size/L
        • label=size/XL
        • label=size/XXL
    • label=kind/bug
    • label=kind/feature

✅ Rule: Dismiss block label if related issue be added into PR (label)

  • all of:
    • any of:
      • base=2.4
      • base~=^2(\.\d+){1,2}$
      • base=2.3
      • base=2.5
      • base=master
    • any of:
      • body~=https://github.com/milvus-io/milvus/issues/[0-9]{1,6}(\s+|$)
      • body~=\#[0-9]{1,6}(\s+|$)

Rule: Blocking PR if missing a related master PR or doesn't have kind/branch-feature label (comment, label)

  • all of:
    • -body~=https://github.com/milvus-io/milvus/pull/[0-9]{1,6}(\s+|$)
    • -body~=pr\:\ \#[0-9]{1,6}(\s+|$)
  • -label=kind/branch-feature
  • -title~=\[automated\]
  • base~=^2(\.\d+){1,2}$

✅ Rule: Dismiss block label if related pr be added into PR (label)

  • base~=^2(\.\d+){1,2}$
  • any of:
    • body~=https://github.com/milvus-io/milvus/pull/[0-9]{1,6}(\s+|$)
    • body~=pr\:\ \#[0-9]{1,6}(\s+|$)
    • label=kind/branch-feature

Rule: Dismiss block label if automated create PR (label)

  • title~=\[automated\]
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Test passed for skip e2e-master (label)

  • title~=\[skip e2e\]
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • status-success=Code Checker AMD64 Ubuntu 22.04
  • status-success=Code Checker MacOS 13
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master
  • any of:
    • status-success=Build and test AMD64 Ubuntu 22.04
    • status-success=Build and test AMD64 Ubuntu 20.04
  • any of:
    • status-success=UT for Cpp
    • status-success=cpp-unit-test
  • any of:
    • status-success=UT for Go
    • status-success=go-unit-test
  • any of:
    • status-success=Integration Test
    • status-success=integration-test

Rule: Test passed for skip e2e - 2.2.* (label)

  • title~=\[skip e2e\]
  • base~=^2(\.\d+){1,2}$
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • status-success=Code Checker MacOS 13
  • any of:
    • status-success=Build and test AMD64 Ubuntu 22.04
    • status-success=Build and test AMD64 Ubuntu 20.04
  • any of:
    • status-success=UT for Cpp
    • status-success=cpp-unit-test
  • any of:
    • status-success=UT for Go
    • status-success=go-unit-test
  • any of:
    • status-success=Integration Test
    • status-success=integration-test

Rule: Assign the 'lgtm' and 'approved' labels following the successful testing of the 'Update Knowhere Commit' (label)

  • title~=Update Knowhere Commit
  • label=ci-passed
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: 2.3 or 2.4 - Remove ci-passed label when status for code checker or ut is not success (label)

  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
    • check-failure=Build and test AMD64 Ubuntu 22.04
    • status-success!=Code Checker MacOS 13
    • status-success!=Integration Test
    • status-success!=UT for Cpp
    • status-success!=UT for Go
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • label!=manual-pass
  • any of:
    • base=2.4
    • base=2.3

Rule: Remove ci-passed label when status for jenkins job is not success (label)

  • status-success!=cpu-e2e
  • -title~=\[skip e2e\]
  • files~=^(?!(.*_test\.go|.*\.md)).*$
  • label!=manual-pass
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when jenkins job failed (comment)

  • check-failure=cpu-e2e
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when go-sdk check failed (comment)

  • check-failure=go-sdk
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when cpp-unit-test check failed (comment)

  • check-failure=cpp-unit-test
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when go-unit-test check failed (comment)

  • check-failure=go-unit-test
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when integration-test check failed (comment)

  • check-failure=integration-test
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when code checker or ut failed -master (comment)

  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Add comment when code checker or ut failed -2.2.* (comment)

  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
  • base~=^2(\.\d+){1,2}$

Rule: Add 'do-not-merge/invalid-pr-format' label for invalid PR titles (comment, label)

  • any of:
    • -title~=^(feat:|enhance:|fix:|test:|doc:|auto:|\[automated\])
    • body=^$
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Remove 'do-not-merge/invalid-pr-format' label for valid PRs (label)

  • label=do-not-merge/invalid-pr-format
  • -body=^$
  • title~=^(feat:|enhance:|fix:|test:|doc:|auto:|\[automated\])
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Label bug fix PRs (label)

  • title~=^fix:
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Label feature PRs (label)

  • title~=^feat:
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

✅ Rule: Label enhancement PRs (label)

  • title~=^enhance:
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Label test PRs (label)

  • title~=^test:
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master

Rule: Label doc PRs (label)

  • title~=^doc:
  • any of:
    • base=2.4
    • base~=^2(\.\d+){1,2}$
    • base=2.3
    • base=2.5
    • base=master
💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!

2 not applicable rules

Rule: Test passed for code changed on master (label)

  • base=master
  • any of:
    • status-success=go-sdk
    • status-success=milvus-sdk-go
  • status-success=Code Checker AMD64 Ubuntu 22.04
  • status-success=Code Checker MacOS 13
  • status-success=cpu-e2e
  • any of:
    • status-success=Build and test AMD64 Ubuntu 22.04
    • status-success=Build and test AMD64 Ubuntu 20.04
  • any of:
    • status-success=UT for Cpp
    • status-success=cpp-unit-test
  • any of:
    • status-success=UT for Go
    • status-success=go-unit-test
  • any of:
    • status-success=Integration Test
    • status-success=integration-test

Rule: master or 2.5 - Remove ci-passed label when status for code checker or ut is not success (label)

  • any of:
    • base=2.5
    • base=master
  • files~=^(?=.*((\.(go|h|cpp)|go.sum|go.mod|CMakeLists.txt|conanfile\.*))).*$
  • label!=manual-pass
  • any of:
    • status-success!=cpp-unit-test
    • check-failure=Build and test AMD64 Ubuntu 20.04
    • check-failure=Build and test AMD64 Ubuntu 22.04
    • status-success!=Code Checker AMD64 Ubuntu 22.04
    • status-success!=Code Checker MacOS 13
    • status-success!=Integration Test
    • status-success!=UT for Go
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

View more details on Mergify