Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compilation failed due to CI conflicts #38222

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: compilation failed due to CI conflicts #38222

merged 1 commit into from
Dec 5, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Dec 5, 2024 •
edited
Loading

issue: #38224

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@jaime0815 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

congqixia
congqixia approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan xiaofan-luan merged commit af288a9 into milvus-io:master Dec 5, 2024
7 of 9 checks passed
@jaime0815 jaime0815 deleted the fix-compile-fail branch December 5, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@congqixia congqixia

Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaime0815 @sre-ci-robot @congqixia @xiaofan-luan