Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix timeout when listing meta #38216

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

When there are too many key-value pairs, the etcd list operation may times out. This PR replaces LoadWithPrefix in list operations, which could involve many keys, with WalkWithPrefix.

issue: #37917

pr: #38151

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 4, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 69.07216% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (febed0a) to head (3cb482a).
Report is 8 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/metastore/kv/datacoord/kv_catalog.go 75.75% 11 Missing and 5 partials ⚠️
internal/metastore/kv/querycoord/kv_catalog.go 54.83% 8 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38216       +/-   ##
===========================================
+ Coverage   70.40%   80.58%   +10.17%     
===========================================
  Files        1074     1074               
  Lines      168099   168110       +11     
===========================================
+ Hits       118353   135471    +17118     
+ Misses      45291    28205    -17086     
+ Partials     4455     4434       -21     
Files with missing lines Coverage Δ
internal/metastore/kv/querycoord/kv_catalog.go 65.63% <54.83%> (+0.32%) ⬆️
internal/metastore/kv/datacoord/kv_catalog.go 73.63% <75.75%> (-0.07%) ⬇️

... and 266 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Dec 6, 2024
@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@czs007 czs007 removed this from the 2.4.18 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants