Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: try compact small segments first if they may compose a full segment (#37709) #38203

Closed
wants to merge 1 commit into from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 4, 2024

See #37234


pr: #37709

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 4, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedxu
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (fcbed3a) to head (ff3cd49).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38203       +/-   ##
===========================================
+ Coverage   68.87%   79.01%   +10.13%     
===========================================
  Files         289     1353     +1064     
  Lines       25481   189424   +163943     
===========================================
+ Hits        17551   149668   +132117     
- Misses       7930    34293    +26363     
- Partials        0     5463     +5463     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 80.79% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/compaction_trigger.go 82.14% <100.00%> (ø)
internal/datacoord/knapsack.go 100.00% <100.00%> (ø)

... and 1062 files with indirect coverage changes

@tedxu tedxu closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants