Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] update web ui #38200

Closed
wants to merge 1 commit into from
Closed

Conversation

mimoning
Copy link
Contributor

@mimoning mimoning commented Dec 4, 2024

issue: #36621
pr: #38137

  • add filters to most of lists
  • add more options to the existing list filter
  • fix the error list column in channels and resource group list

Signed-off-by: mimo.oyn <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mimoning
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@mimoning Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug and removed do-not-merge/missing-related-pr labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (fcbed3a) to head (7ab69e4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38200       +/-   ##
===========================================
+ Coverage   68.87%   81.02%   +12.14%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190678   +165197     
===========================================
+ Hits        17551   154502   +136951     
- Misses       7930    30673    +22743     
- Partials        0     5503     +5503     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.19% <ø> (∅)

see 1071 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 4, 2024
@mimoning mimoning closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants