Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add list aliases privilege into public role #38176

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shaoting-huang
Copy link
Contributor

related issue: #37031

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 3, 2024
@shaoting-huang
Copy link
Contributor Author

shaoting-huang commented Dec 3, 2024

>>> role.list_grants()
GrantInfo groups:
>>> utility.create_alias("binbin_new", "binbin_new_alias")
>>> connections.disconnect('default')
>>> connections.connect(host="localhost", user="user1", password="Milvus")
>>> utility.list_aliases("binbin_new")
['binbin_new_alias']

Copy link
Contributor

mergify bot commented Dec 3, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (6f1b1ad) to head (8e3438c).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38176      +/-   ##
==========================================
- Coverage   81.12%   81.09%   -0.04%     
==========================================
  Files        1372     1372              
  Lines      191257   191349      +92     
==========================================
+ Hits       155157   155173      +16     
- Misses      30630    30679      +49     
- Partials     5470     5497      +27     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.21% <100.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/root_coord.go 89.39% <100.00%> (+<0.01%) ⬆️

... and 32 files with indirect coverage changes

@shaoting-huang shaoting-huang changed the title enhance: add describe alias privilege into public role enhance: add list aliases privilege into public role Dec 3, 2024
@weiliu1031
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 3, 2024
@sre-ci-robot sre-ci-robot merged commit d822edb into milvus-io:master Dec 3, 2024
19 of 20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 4, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 4, 2024
…po (#38208)

cherry-pick from master: #38176,
#38195
related issue: #37031

---------

Signed-off-by: shaoting-huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants