Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add ctx param to KV operation interfaces #38154

Merged
merged 1 commit into from
Dec 5, 2024

refine interfaces for kv operation

423765a
Select commit
Loading
Failed to load commit list.
Merged

enhance: Add ctx param to KV operation interfaces #38154

refine interfaces for kv operation
423765a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

81.08% (target 77.00%)

View this Pull Request on Codecov

81.08% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 94.00480% with 25 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (e359725) to head (423765a).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
internal/kv/etcd/etcd_kv.go 88.67% 6 Missing ⚠️
internal/kv/etcd/embed_etcd_kv.go 92.85% 4 Missing ⚠️
internal/metastore/kv/rootcoord/kv_catalog.go 95.18% 3 Missing and 1 partial ⚠️
internal/kv/mem/mem_kv.go 86.36% 3 Missing ⚠️
internal/metastore/kv/rootcoord/suffix_snapshot.go 92.85% 3 Missing ⚠️
internal/metastore/kv/datacoord/kv_catalog.go 96.92% 2 Missing ⚠️
internal/datacoord/channel_store.go 66.66% 1 Missing ⚠️
internal/metastore/kv/querycoord/kv_catalog.go 95.00% 1 Missing ⚠️
pkg/mq/mqimpl/rocksmq/server/rocksmq_impl.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38154      +/-   ##
==========================================
- Coverage   81.11%   81.08%   -0.03%     
==========================================
  Files        1372     1372              
  Lines      191350   191480     +130     
==========================================
+ Hits       155219   155270      +51     
- Misses      30646    30710      +64     
- Partials     5485     5500      +15
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.88% <ø> (+<0.01%) ⬆️
Go 83.21% <94.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.79% <100.00%> (+0.80%) ⬆️
internal/kv/tikv/txn_tikv.go 83.24% <100.00%> (ø)
internal/metastore/kv/streamingcoord/kv_catalog.go 81.25% <100.00%> (ø)
internal/metastore/kv/streamingnode/kv_catalog.go 76.00% <100.00%> (ø)
internal/querycoordv2/meta/resource_manager.go 82.07% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/server.go 79.53% <100.00%> (ø)
internal/tso/tso.go 81.25% <100.00%> (ø)
pkg/kv/kv.go 0.00% <ø> (ø)
pkg/kv/rocksdb/rocksdb_kv.go 80.11% <100.00%> (ø)
pkg/mq/mqimpl/rocksmq/server/rocksmq_retention.go 76.72% <100.00%> (ø)
... and 9 more

... and 45 files with indirect coverage changes

View more details on Codecov