Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] fix grant/revoke v2 meta and unclear error messages #38146

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Dec 2, 2024

cherry-pick from #38110, #38130
related issue: #37031

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Dec 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (b29237e) to head (64c4b91).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 87.87% 3 Missing and 1 partial ⚠️
internal/proxy/util.go 93.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38146      +/-   ##
==========================================
+ Coverage   72.27%   80.58%   +8.31%     
==========================================
  Files        1073     1073              
  Lines      167708   167763      +55     
==========================================
+ Hits       121203   135193   +13990     
+ Misses      42078    28137   -13941     
- Partials     4427     4433       +6     
Files with missing lines Coverage Δ
internal/proxy/impl.go 85.00% <100.00%> (+0.21%) ⬆️
internal/rootcoord/meta_table.go 83.72% <100.00%> (+0.02%) ⬆️
pkg/util/constant.go 98.36% <100.00%> (+8.19%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 83.65% <100.00%> (+0.12%) ⬆️
internal/proxy/util.go 90.82% <93.33%> (+<0.01%) ⬆️
internal/rootcoord/root_coord.go 89.30% <87.87%> (-0.04%) ⬇️

... and 233 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 3, 2024
@czs007 czs007 added this to the 2.4.18 milestone Dec 3, 2024
@mergify mergify bot removed the ci-passed label Dec 3, 2024
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Dec 3, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 3, 2024
Copy link
Contributor

mergify bot commented Dec 3, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

pkg/util/merr/utils.go Outdated Show resolved Hide resolved
@czs007
Copy link
Collaborator

czs007 commented Dec 3, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 3, 2024
@sre-ci-robot sre-ci-robot merged commit 66f2dac into milvus-io:2.4 Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants