Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] pick some master improvements to 2.4 branch #38128

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.31%. Comparing base (8646bba) to head (fe5a41f).
Report is 35 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/task_insert.go 33.33% 3 Missing and 1 partial ⚠️
internal/proxy/task_upsert.go 33.33% 3 Missing and 1 partial ⚠️
internal/rootcoord/root_coord.go 42.85% 3 Missing and 1 partial ⚠️
internal/rootcoord/meta_table.go 50.00% 2 Missing and 1 partial ⚠️
pkg/util/retry/retry.go 92.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38128      +/-   ##
==========================================
- Coverage   80.54%   72.31%   -8.24%     
==========================================
  Files        1074     1074              
  Lines      168273   168325      +52     
==========================================
- Hits       135534   121719   -13815     
- Misses      28289    42168   +13879     
+ Partials     4450     4438      -12     
Files with missing lines Coverage Δ
internal/metastore/model/database.go 100.00% <100.00%> (ø)
internal/proxy/meta_cache.go 89.97% <100.00%> (-0.20%) ⬇️
internal/proxy/msg_pack.go 73.19% <100.00%> (+0.13%) ⬆️
internal/proxy/rate_limit_interceptor.go 100.00% <100.00%> (ø)
internal/proxy/task_delete.go 92.24% <100.00%> (-0.02%) ⬇️
internal/querynodev2/services.go 86.73% <100.00%> (-0.39%) ⬇️
internal/rootcoord/create_collection_task.go 94.41% <100.00%> (+0.01%) ⬆️
internal/rootcoord/drop_collection_task.go 100.00% <100.00%> (ø)
internal/util/pipeline/stream_pipeline.go 93.65% <100.00%> (ø)
pkg/util/funcutil/func.go 91.06% <100.00%> (+0.17%) ⬆️
... and 6 more

... and 233 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 2, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 3, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 3, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 4, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 5, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 5, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 5, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SimFG <[email protected]>
Copy link
Contributor

mergify bot commented Dec 5, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 5, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 13, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit df73f93 into milvus-io:2.4 Dec 13, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants