-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config field to set internal tls sni #38124
Conversation
@haorenfsa: GitHub didn't allow me to request PR reviews from the following users: nish112022. Note that only milvus-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
d4c4caa
to
1bcf6e4
Compare
@haorenfsa go-sdk check failed, comment |
@haorenfsa E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38124 +/- ##
===========================================
+ Coverage 68.87% 81.09% +12.22%
===========================================
Files 289 1370 +1081
Lines 25484 191119 +165635
===========================================
+ Hits 17551 154992 +137441
- Misses 7933 30646 +22713
- Partials 0 5481 +5481
|
1bcf6e4
to
101c5c4
Compare
@haorenfsa go-sdk check failed, comment |
@haorenfsa E2e jenkins job failed, comment |
101c5c4
to
640b8a3
Compare
@haorenfsa E2e jenkins job failed, comment |
640b8a3
to
59cfa18
Compare
@haorenfsa go-sdk check failed, comment |
Signed-off-by: haorenfsa <[email protected]>
59cfa18
to
5966d42
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: haorenfsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @xiaofan-luan @jaime0815 @nish112022
part of #36864