Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config field to set internal tls sni #38124

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

haorenfsa
Copy link
Contributor

@sre-ci-robot
Copy link
Contributor

@haorenfsa: GitHub didn't allow me to request PR reviews from the following users: nish112022.

Note that only milvus-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xiaofan-luan @jaime0815 @nish112022

part of #36864

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@haorenfsa haorenfsa changed the title add config field to set internal tls sni feature: add config field to set internal tls sni Dec 2, 2024
@haorenfsa haorenfsa changed the title feature: add config field to set internal tls sni feat: add config field to set internal tls sni Dec 2, 2024
@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/invalid-pr-format labels Dec 2, 2024
@haorenfsa haorenfsa force-pushed the internal-tls branch 2 times, most recently from d4c4caa to 1bcf6e4 Compare December 2, 2024 03:36
Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (4c623ce) to head (5966d42).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/mock/grpcclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38124       +/-   ##
===========================================
+ Coverage   68.87%   81.09%   +12.22%     
===========================================
  Files         289     1370     +1081     
  Lines       25484   191119   +165635     
===========================================
+ Hits        17551   154992   +137441     
- Misses       7933    30646    +22713     
- Partials        0     5481     +5481     
Components Coverage Δ
Client 73.67% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.23% <93.10%> (∅)
Files with missing lines Coverage Δ
internal/distributed/datacoord/client/client.go 96.19% <100.00%> (ø)
internal/distributed/datanode/client/client.go 89.61% <100.00%> (ø)
internal/distributed/indexnode/client/client.go 85.43% <100.00%> (ø)
internal/distributed/proxy/client/client.go 93.52% <100.00%> (ø)
internal/distributed/querycoord/client/client.go 95.80% <100.00%> (ø)
internal/distributed/querynode/client/client.go 91.51% <100.00%> (ø)
internal/distributed/rootcoord/client/client.go 94.93% <100.00%> (ø)
internal/util/grpcclient/client.go 99.23% <100.00%> (ø)
pkg/util/paramtable/grpc_param.go 85.85% <100.00%> (ø)
internal/util/mock/grpcclient.go 58.24% <0.00%> (ø)

... and 1071 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@haorenfsa go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 2, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 2, 2024
@mergify mergify bot added the ci-passed label Dec 2, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1f66b9e into milvus-io:master Dec 4, 2024
20 checks passed
@haorenfsa haorenfsa deleted the internal-tls branch December 4, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants