fix: Return thread watcher goroutine after closed #38091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
/lgtm |
Resolves milvus-io#38090 Signed-off-by: Congqi Xia <[email protected]>
congqixia
force-pushed
the
fix/quit_thread_watcher
branch
from
acd1d9e to
2c473e8
Compare
|
/lgtm |
|
@congqixia go-sdk check failed, comment |
|
rerun go-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38091 +/- ##
==========================================
+ Coverage 81.06% 81.08% +0.02%
==========================================
Files 1369 1369
Lines 190967 190968 +1
==========================================
+ Hits 154799 154849 +50
+ Misses 30680 30637 -43
+ Partials 5488 5482 -6
|
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Nov 29, 2024
Resolves milvus-io#38090 Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 2, 2024
) Cherry-pick from master pr: #38091 Resolves #38090 Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #38090