-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.4] Fix inaccurate partition num metric #38073
Conversation
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #38073 +/- ##
==========================================
+ Coverage 79.62% 79.64% +0.02%
==========================================
Files 1073 1073
Lines 167746 167744 -2
==========================================
+ Hits 133569 133608 +39
+ Misses 29734 29699 -35
+ Partials 4443 4437 -6
|
/approve |
/run-cpu-e2e |
@bigsheeper E2e jenkins job failed, comment |
…um-partition-2.4
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The partition number has already been incremented in ChangePartitionState, so there is no need to increment it again in AddPartition.
issue: #37630
pr: #37996