Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix inaccurate partition num metric #38073

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

bigsheeper
Copy link
Contributor

The partition number has already been incremented in ChangePartitionState, so there is no need to increment it again in AddPartition.

issue: #37630

pr: #37996

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 28, 2024
Copy link
Contributor

mergify bot commented Nov 28, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (03f01d8) to head (a4ce7af).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38073      +/-   ##
==========================================
+ Coverage   79.62%   79.64%   +0.02%     
==========================================
  Files        1073     1073              
  Lines      167746   167744       -2     
==========================================
+ Hits       133569   133608      +39     
+ Misses      29734    29699      -35     
+ Partials     4443     4437       -6     
Files with missing lines Coverage Δ
internal/rootcoord/meta_table.go 83.67% <ø> (-0.03%) ⬇️

... and 30 files with indirect coverage changes

@bigsheeper bigsheeper added this to the 2.4.18 milestone Dec 2, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 2, 2024

/approve
/lgtm

@czs007
Copy link
Collaborator

czs007 commented Dec 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 3, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 3, 2024
@mergify mergify bot added the ci-passed label Dec 3, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7b82417 into milvus-io:2.4 Dec 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants