Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] support recall estimation #38064

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

chasingegg
Copy link
Contributor

issue: #37899
pr: #38017

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 28, 2024
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/internal-api labels Nov 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 69.72477% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (6b310e1) to head (8e6853c).
Report is 13 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/impl.go 35.71% 16 Missing and 2 partials ⚠️
internal/proxy/util.go 89.47% 6 Missing ⚠️
internal/proxy/task_search.go 40.00% 2 Missing and 1 partial ⚠️
internal/querynodev2/optimizers/query_hook.go 57.14% 2 Missing and 1 partial ⚠️
internal/querynodev2/segments/result.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38064      +/-   ##
==========================================
+ Coverage   80.40%   83.38%   +2.98%     
==========================================
  Files        1077      809     -268     
  Lines      168911   142524   -26387     
==========================================
- Hits       135811   118843   -16968     
+ Misses      28648    19220    -9428     
- Partials     4452     4461       +9     
Files with missing lines Coverage Δ
internal/querynodev2/services.go 86.82% <100.00%> (+0.08%) ⬆️
pkg/common/common.go 73.84% <ø> (ø)
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
internal/proxy/task_search.go 74.62% <40.00%> (-0.19%) ⬇️
internal/querynodev2/optimizers/query_hook.go 80.82% <57.14%> (-2.52%) ⬇️
internal/querynodev2/segments/result.go 69.68% <40.00%> (-0.27%) ⬇️
internal/proxy/util.go 90.82% <89.47%> (-0.06%) ⬇️
internal/proxy/impl.go 83.86% <35.71%> (-0.21%) ⬇️

... and 303 files with indirect coverage changes

prometheus.CounterOpts{
Namespace: milvusNamespace,
Subsystem: typeutil.ProxyRole,
Name: "recall_serch_cnt",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo of serch

@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 11, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: chasingegg <[email protected]>
@mergify mergify bot added the ci-passed label Dec 11, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit d7e926f into milvus-io:2.4 Dec 11, 2024
14 of 15 checks passed
@chasingegg chasingegg deleted the recall-search2.4 branch December 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants