-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.4] support recall estimation #38064
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #38064 +/- ##
==========================================
+ Coverage 80.40% 83.38% +2.98%
==========================================
Files 1077 809 -268
Lines 168911 142524 -26387
==========================================
- Hits 135811 118843 -16968
+ Misses 28648 19220 -9428
- Partials 4452 4461 +9
|
efaace6
to
e205a4d
Compare
Signed-off-by: chasingegg <[email protected]>
e205a4d
to
a921b00
Compare
pkg/metrics/proxy_metrics.go
Outdated
prometheus.CounterOpts{ | ||
Namespace: milvusNamespace, | ||
Subsystem: typeutil.ProxyRole, | ||
Name: "recall_serch_cnt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo of serch
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chasingegg E2e jenkins job failed, comment |
Signed-off-by: chasingegg <[email protected]>
/lgtm |
issue: #37899
pr: #38017