Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix variable redeclaration in term filter #38045

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 27, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 27, 2024
Copy link
Contributor

mergify bot commented Nov 27, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@sunby sunby changed the title fix: Fix using wrong index in term filter fix: Fix variable redeclaration in term filter Nov 27, 2024
Copy link
Contributor

mergify bot commented Nov 27, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 27, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (6b23e66) to head (edbee9c).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38045       +/-   ##
===========================================
+ Coverage   68.87%   81.05%   +12.18%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190840   +165359     
===========================================
+ Hits        17551   154693   +137142     
- Misses       7930    30650    +22720     
- Partials        0     5497     +5497     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.22% <ø> (∅)

see 1360 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

rerun cpp-unit-test

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 29, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 29, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 29, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 90064cd into milvus-io:master Dec 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants