Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4]Check if the dynamic fields contain any static fields #38027

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #38024

master pr: #38025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333 xiaocai2333 force-pushed the check_field_exist_dynamic-4 branch from fa8fe22 to 2842b6e Compare November 29, 2024 05:34
Copy link
Contributor

mergify bot commented Nov 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (a71d49d) to head (2842b6e).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38027      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.02%     
==========================================
  Files        1070     1070              
  Lines      167554   167552       -2     
==========================================
- Hits       135114   135092      -22     
- Misses      28017    28031      +14     
- Partials     4423     4429       +6     
Files with missing lines Coverage Δ
internal/proxy/util.go 90.82% <100.00%> (+0.05%) ⬆️
internal/proxy/validate_util.go 87.07% <ø> (-0.27%) ⬇️

... and 33 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 added this to the 2.4.18 milestone Dec 2, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 2, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 2, 2024
@sre-ci-robot sre-ci-robot merged commit 580caeb into milvus-io:2.4 Dec 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants