Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: the actual number of databases should equal the config value #38009

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jaime0815
Copy link
Contributor

pr: #38006

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.4@b245101). Learn more about missing BASE report.
Report is 6 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.4   #38009   +/-   ##
======================================
  Coverage       ?   72.27%           
======================================
  Files          ?     1070           
  Lines          ?   167374           
  Branches       ?        0           
======================================
  Hits           ?   120962           
  Misses         ?    41975           
  Partials       ?     4437           
Files with missing lines Coverage Δ
internal/rootcoord/create_db_task.go 84.21% <100.00%> (ø)

@czs007 czs007 modified the milestones: 2.4.17, 2.4.18 Nov 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1c8f14e into milvus-io:2.4 Nov 26, 2024
14 of 15 checks passed
@jaime0815 jaime0815 deleted the max-db-algin-config-24 branch November 26, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants