Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: optimize self defined rust error #37975

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 25, 2024

Prepare for issue: #37930

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 26, 2024

rerun cpp-unit-test

@sunby
Copy link
Contributor Author

sunby commented Nov 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (fbb68ca) to head (938b6aa).
Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37975      +/-   ##
==========================================
- Coverage   81.07%   81.05%   -0.02%     
==========================================
  Files        1360     1360              
  Lines      190775   190776       +1     
==========================================
- Hits       154671   154640      -31     
- Misses      30620    30644      +24     
- Partials     5484     5492       +8     
Components Coverage Δ
Client 72.33% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.22% <ø> (-0.02%) ⬇️

see 39 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Nov 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 27, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 27, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 28, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Nov 28, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 28, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Nov 28, 2024

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Nov 28, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e6af806 into milvus-io:master Nov 28, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants