Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit the concurrency of channel tasks #37740

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

bigsheeper
Copy link
Contributor

Limit the maximum concurrency of channel tasks for each DataNode to prevent excessive subscriptions from causing DataNode OOM.

issue: #37665

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 16, 2024
Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (3cdb485) to head (cd2cc06).
Report is 26 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37740       +/-   ##
===========================================
+ Coverage   68.91%   82.51%   +13.59%     
===========================================
  Files         290     1067      +777     
  Lines       25471   165287   +139816     
===========================================
+ Hits        17553   136380   +118827     
- Misses       7918    23478    +15560     
- Partials        0     5429     +5429     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.21% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/channel_manager.go 87.66% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.35% <100.00%> (ø)

... and 1355 files with indirect coverage changes

---- 🚨 Try these New Features:

@czs007
Copy link
Collaborator

czs007 commented Nov 16, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0fc0d1a into milvus-io:master Nov 18, 2024
20 checks passed
@bigsheeper bigsheeper added the PR | need cherry-pick need cherry pick to other branches label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm PR | need cherry-pick need cherry pick to other branches size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants