Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix query failure with inverted index #37686

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 14, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (1b4f7e3) to head (648ccf3).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1b4f7e3) and HEAD (648ccf3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1b4f7e3) HEAD (648ccf3)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37686       +/-   ##
===========================================
- Coverage   80.63%   68.91%   -11.73%     
===========================================
  Files        1357      290     -1067     
  Lines      190463    25457   -165006     
===========================================
- Hits       153589    17544   -136045     
+ Misses      31462     7913    -23549     
+ Partials     5412        0     -5412     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.91% <100.00%> (+0.26%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/exec/expression/CompareExpr.h 79.68% <100.00%> (+3.90%) ⬆️

... and 1070 files with indirect coverage changes

Signed-off-by: sunby <[email protected]>
@sunby sunby force-pushed the fix_chunked_query_index branch from af6d71d to 648ccf3 Compare November 14, 2024 12:13
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 14, 2024
@mergify mergify bot added the ci-passed label Nov 14, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d159629 into milvus-io:master Nov 15, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants