Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make GetShardLeaders skip retry on not loaded collection #37684

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #37532

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (1304b40) to head (5fc2687).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37684      +/-   ##
==========================================
- Coverage   80.57%   80.55%   -0.02%     
==========================================
  Files        1357     1357              
  Lines      190448   190463      +15     
==========================================
- Hits       153449   153434      -15     
- Misses      31588    31613      +25     
- Partials     5411     5416       +5     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.07% <ø> (-0.01%) ⬇️
Go 83.18% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/lb_policy.go 98.06% <100.00%> (ø)

... and 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 14, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 14, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c5485bb into milvus-io:master Nov 14, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants