Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lost loading collection's updateTs after qc restart #37538

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #37537

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 8, 2024
Copy link
Contributor

mergify bot commented Nov 8, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (0f51470) to head (34812c5).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37538      +/-   ##
==========================================
- Coverage   80.58%   80.56%   -0.02%     
==========================================
  Files        1356     1356              
  Lines      189213   190016     +803     
==========================================
+ Hits       152471   153092     +621     
- Misses      31381    31510     +129     
- Partials     5361     5414      +53     
Components Coverage Δ
Client 60.27% <ø> (ø)
Core 68.13% <ø> (ø)
Go 83.21% <100.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/meta/collection_manager.go 86.53% <100.00%> (+0.20%) ⬆️

... and 52 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 8, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 8, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

m.collections[collection.CollectionID] = &Collection{
CollectionLoadInfo: collection,
CreatedAt: time.Now(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partition may has the same issue?

@weiliu1031 weiliu1031 force-pushed the fix_recover_collection branch from af0735f to 34812c5 Compare November 11, 2024 02:21
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

@weiliu1031 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 11, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 61a5b15 into milvus-io:master Nov 11, 2024
19 of 20 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Nov 11, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants