Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Escape brace of dumped JSON for index err message #37504

Merged

Conversation

congqixia
Copy link
Contributor

Related to #37503

@congqixia congqixia changed the title fix: Escape brace for dumped JSON for index err message fix: Escape brace of dumped JSON for index err message Nov 7, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 7, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (7cfd609) to head (dfa3f63).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37504       +/-   ##
===========================================
- Coverage   83.23%   67.30%   -15.94%     
===========================================
  Files        1015      290      -725     
  Lines      157697    25400   -132297     
===========================================
- Hits       131260    17095   -114165     
+ Misses      21228     8305    -12923     
+ Partials     5209        0     -5209     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.30% <48.52%> (∅)
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/VectorMemIndex.cpp 64.82% <100.00%> (ø)

... and 1304 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 7, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Nov 7, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 5310d34 into milvus-io:master Nov 7, 2024
18 of 20 checks passed
@congqixia congqixia deleted the fix/escape_brace_json_dump branch November 8, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants