Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "enhance: Support db for bulkinsert (#37012)" #37420

Merged

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Nov 4, 2024

This reverts commit 6e90f9e.

issue: #31273

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 4, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

@bigsheeper

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@bigsheeper bigsheeper changed the title Revert "enhance: Support db for bulkinsert (#37012)" fix: Revert "enhance: Support db for bulkinsert (#37012)" Nov 4, 2024
@mergify mergify bot added the kind/bug Issues or changes related a bug label Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (aed3b94) to head (89edbb9).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/services.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37420      +/-   ##
==========================================
+ Coverage   81.03%   83.25%   +2.21%     
==========================================
  Files        1305     1015     -290     
  Lines      183190   157768   -25422     
==========================================
- Hits       148455   131351   -17104     
+ Misses      29533    21215    -8318     
  Partials     5202     5202              
Components Coverage Δ
Client ∅ <ø> (∅)
Core ∅ <ø> (∅)
Go 83.28% <77.77%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/import_job.go 100.00% <ø> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 91.97% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)
internal/proxy/impl.go 85.29% <100.00%> (-0.07%) ⬇️
internal/datacoord/services.go 85.91% <60.00%> (-0.13%) ⬇️

... and 319 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Nov 5, 2024
Copy link
Contributor

mergify bot commented Nov 5, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 7, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 994f52f into milvus-io:master Nov 7, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants