Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add IP address validation from paramtable #37416

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix: Add IP address validation from paramtable #37416

merged 3 commits into from
Nov 7, 2024

Conversation

congqixia
Copy link
Contributor

See also #37404 #37402

IP address in paramtable need validation and fail fast with reasonable error message

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 4, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (c83b939) to head (18c5d93).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37416       +/-   ##
===========================================
+ Coverage   67.37%   81.05%   +13.67%     
===========================================
  Files         290     1305     +1015     
  Lines       25378   183054   +157676     
===========================================
+ Hits        17098   148368   +131270     
- Misses       8280    29482    +21202     
- Partials        0     5204     +5204
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.37% <ø> (ø)
Go 83.27% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/funcutil/func.go 90.46% <100.00%> (ø)

... and 1014 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia
Copy link
Contributor Author

/hold

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the fix/add_config_ip_validation branch from 142d82d to 497e823 Compare November 5, 2024 02:35
@congqixia
Copy link
Contributor Author

/unhold

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 5, 2024
@congqixia
fix: Add IP address validation from paramtable
8158317 
See also milvus-io#37404 milvus-io#37402

IP address in paramtable need validation and fail fast with reasonable
error message

Signed-off-by: Congqi Xia <[email protected]>
@congqixia
do not panic when input ip not in ip format
89acc3d 
Signed-off-by: Congqi Xia <[email protected]>
@congqixia
Fix unit test message
18c5d93 
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the fix/add_config_ip_validation branch from 497e823 to 18c5d93 Compare November 6, 2024 06:57
@mergify mergify bot removed the ci-passed label Nov 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 6, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6325d02 into milvus-io:master Nov 7, 2024
20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 7, 2024
@congqixia
fix: Add IP address validation from paramtable (milvus-io#37416)
000c1b2 
See also milvus-io#37404 milvus-io#37402

IP address in paramtable need validation and fail fast with reasonable
error message

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Nov 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 11, 2024
@congqixia
fix: [2.4] Add IP address validation from paramtable (#37416) (#37500)
4f42611 
Cherry-pick from master
pr: #37416
See also #37404 #37402

IP address in paramtable need validation and fail fast with reasonable
error message

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the fix/add_config_ip_validation branch November 11, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @weiliu1031