-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Optimize the performance of stats task #37374
Conversation
These optimizations reduced the stats task time from 15s to 7s (1 million 128-dim end-to-end test).
After:
|
Signed-off-by: bigsheeper <[email protected]>
c277e80
to
914d76d
Compare
@bigsheeper go-sdk check failed, comment |
@bigsheeper E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37374 +/- ##
==========================================
- Coverage 81.03% 81.02% -0.02%
==========================================
Files 1305 1305
Lines 183190 183212 +22
==========================================
- Hits 148455 148453 -2
- Misses 29533 29548 +15
- Partials 5202 5211 +9
|
/lgtm need to fix the ut |
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper go-sdk check failed, comment |
@bigsheeper E2e jenkins job failed, comment |
@bigsheeper cpp-unit-test check failed, comment |
@bigsheeper cpp-unit-test check failed, comment |
@bigsheeper E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun cpp-unit-test |
@bigsheeper E2e jenkins job failed, comment |
/run-cpu-e2e |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
batchSize
to avoid multiple serialization operations.writer.Flush()
.issue: #37373