Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support iterative filter execution #37363

Merged
merged 5 commits into from
Dec 11, 2024

update

6881210
Select commit
Loading
Failed to load commit list.
Merged

enhance: support iterative filter execution #37363

update
6881210
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 1s

81.06% (target 77.00%)

View this Pull Request on Codecov

81.06% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 81.86851% with 262 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (618f0cb) to head (6881210).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/Expr.h 52.03% 59 Missing ⚠️
...nal/core/src/exec/operator/IterativeFilterNode.cpp 76.51% 31 Missing ⚠️
internal/core/src/exec/expression/CompareExpr.h 64.61% 23 Missing ⚠️
internal/core/src/exec/expression/ColumnExpr.cpp 65.78% 13 Missing ⚠️
internal/core/src/exec/operator/Utils.h 53.57% 13 Missing ⚠️
internal/core/src/common/Chunk.cpp 8.33% 11 Missing ⚠️
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 96.09% 10 Missing ⚠️
internal/core/src/exec/expression/ColumnExpr.h 0.00% 8 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 92.72% 8 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.h 72.41% 8 Missing ⚠️
... and 18 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37363      +/-   ##
==========================================
- Coverage   81.08%   81.06%   -0.02%     
==========================================
  Files        1372     1375       +3     
  Lines      191564   192216     +652     
==========================================
+ Hits       155324   155825     +501     
- Misses      30740    30901     +161     
+ Partials     5500     5490      -10     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.93% <81.79%> (+0.08%) ⬆️
Go 83.22% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/common/Chunk.h 60.71% <100.00%> (+0.47%) ⬆️
internal/core/src/common/QueryInfo.h 100.00% <ø> (ø)
internal/core/src/exec/Driver.cpp 81.39% <100.00%> (+0.44%) ⬆️
internal/core/src/exec/QueryContext.h 84.61% <100.00%> (+0.30%) ⬆️
...ternal/core/src/exec/expression/AlwaysTrueExpr.cpp 88.23% <100.00%> (+2.52%) ⬆️
...e/src/exec/expression/BinaryArithOpEvalRangeExpr.h 100.00% <100.00%> (ø)
...nternal/core/src/exec/expression/BinaryRangeExpr.h 94.00% <100.00%> (+1.31%) ⬆️
internal/core/src/exec/expression/CallExpr.cpp 100.00% <100.00%> (ø)
internal/core/src/exec/expression/EvalCtx.h 100.00% <100.00%> (ø)
internal/core/src/exec/expression/ExistsExpr.cpp 89.47% <100.00%> (+2.37%) ⬆️
... and 47 more

... and 32 files with indirect coverage changes