Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: improve rootcoord task scheduling policy #37352

Merged
merged 1 commit into from
Nov 6, 2024

enhance: improve rootcoord task scheduling policy

b746aa3
Select commit
Loading
Failed to load commit list.
Merged

enhance: improve rootcoord task scheduling policy #37352

enhance: improve rootcoord task scheduling policy
b746aa3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2024 in 0s

81.05% (target 77.00%)

View this Pull Request on Codecov

81.05% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 94.35897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (b3de4b0) to head (b746aa3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/scheduler.go 85.00% 4 Missing and 2 partials ⚠️
internal/rootcoord/task.go 88.63% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37352      +/-   ##
==========================================
- Coverage   83.25%   81.05%   -2.21%     
==========================================
  Files        1015     1305     +290     
  Lines      157480   183044   +25564     
==========================================
+ Hits       131116   148362   +17246     
- Misses      21172    29477    +8305     
- Partials     5192     5205      +13     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.37% <ø> (∅)
Go 83.27% <94.35%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/alter_alias_task.go 100.00% <100.00%> (ø)
internal/rootcoord/alter_collection_task.go 95.18% <100.00%> (+0.44%) ⬆️
internal/rootcoord/alter_database_task.go 87.35% <100.00%> (+0.77%) ⬆️
internal/rootcoord/create_alias_task.go 100.00% <100.00%> (ø)
internal/rootcoord/create_collection_task.go 90.27% <100.00%> (+0.09%) ⬆️
internal/rootcoord/create_db_task.go 84.21% <100.00%> (+1.85%) ⬆️
internal/rootcoord/create_partition_task.go 91.30% <100.00%> (+0.71%) ⬆️
internal/rootcoord/describe_collection_task.go 87.50% <100.00%> (+5.14%) ⬆️
internal/rootcoord/describe_db_task.go 100.00% <100.00%> (ø)
internal/rootcoord/drop_alias_task.go 100.00% <100.00%> (ø)
... and 13 more

... and 319 files with indirect coverage changes