Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cp25] Update Knowhere version #37332

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Oct 31, 2024

/kind branch-feature

@sre-ci-robot sre-ci-robot added kind/branch-feature area/compilation size/XS Denotes a PR that changes 0-9 lines. labels Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (e714e42) to head (bf3cf42).
Report is 6 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37332      +/-   ##
==========================================
- Coverage   83.11%   80.86%   -2.26%     
==========================================
  Files        1032     1322     +290     
  Lines      157799   183225   +25426     
==========================================
+ Hits       131153   148161   +17008     
- Misses      21449    29864    +8415     
- Partials     5197     5200       +3     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.92% <ø> (∅)
Go 83.13% <ø> (-0.01%) ⬇️

see 318 files with indirect coverage changes

@foxspy
Copy link
Contributor Author

foxspy commented Oct 31, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the update_knowhere_version_25 branch from ee12b5a to bf3cf42 Compare November 1, 2024 08:46
@mergify mergify bot removed the ci-passed label Nov 1, 2024
Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 2, 2024

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 4, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ae1bb01 into milvus-io:2.5 Nov 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/test ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants