Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [cp24]l0RowCount metrics value always empty #37307

Merged
merged 5 commits into from
Nov 4, 2024
Merged

fix: [cp24]l0RowCount metrics value always empty #37307

merged 5 commits into from
Nov 4, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #36953
pr: #37306

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 30, 2024
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (37d691f) to head (99e8d3c).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37307      +/-   ##
==========================================
+ Coverage   79.05%   80.58%   +1.53%     
==========================================
  Files        1061     1069       +8     
  Lines      164564   165666    +1102     
==========================================
+ Hits       130088   133496    +3408     
+ Misses      30108    27806    -2302     
+ Partials     4368     4364       -4
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.24% <100.00%> (+2.50%) ⬆️
internal/datacoord/segment_info.go 86.30% <100.00%> (+2.39%) ⬆️

... and 184 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 1, 2024
@mergify mergify bot removed the ci-passed label Nov 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
fix store deltaRowcount
b88de14 
Signed-off-by: yangxuan <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 4, 2024
congqixia
congqixia approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 28fd217 into milvus-io:2.4 Nov 4, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/fix-l0-metrics branch November 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuanYang-cn @sre-ci-robot @congqixia