Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add SearchOnSealed unit test and fix a bug (#37241) #37293

Closed
wants to merge 1 commit into from

fix: add SearchOnSealed unit test and fix a bug (#37241)

552b10e
Select commit
Loading
Failed to load commit list.
Closed

fix: add SearchOnSealed unit test and fix a bug (#37241) #37293

fix: add SearchOnSealed unit test and fix a bug (#37241)
552b10e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

80.90% (target 77.00%)

View this Pull Request on Codecov

80.90% (target 77.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (ee6ce8c) to head (552b10e).
Report is 4 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37293      +/-   ##
==========================================
- Coverage   83.14%   80.90%   -2.24%     
==========================================
  Files        1029     1319     +290     
  Lines      157291   182771   +25480     
==========================================
+ Hits       130778   147870   +17092     
- Misses      21342    29728    +8386     
- Partials     5171     5173       +2     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.15% <100.00%> (∅)
Go 83.15% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/mmap/ChunkedColumn.h 9.23% <100.00%> (ø)
internal/core/src/query/SearchOnSealed.cpp 95.19% <100.00%> (ø)

... and 320 files with indirect coverage changes