Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Rename textmatch to text_match #37290

Merged
merged 1 commit into from
Nov 3, 2024
Merged

enhance: Rename textmatch to text_match #37290

merged 1 commit into from
Nov 3, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36672

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 30, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Oct 30, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (d119a25) to head (0ff41b3).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37290      +/-   ##
==========================================
- Coverage   83.24%   81.01%   -2.23%     
==========================================
  Files        1015     1305     +290     
  Lines      157421   182858   +25437     
==========================================
+ Hits       131040   148137   +17097     
- Misses      21184    29521    +8337     
- Partials     5197     5200       +3
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (∅)
Go 83.26% <81.31%> (+<0.01%) ⬆️

see 319 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Oct 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun ut

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Oct 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 2, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 3, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 50de122 into milvus-io:master Nov 3, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 3, 2024
@xiaocai2333
enhance: [2.5]Rename textmatch to text_match (#37291)
3e4dbd9 
issue: #36672 

master pr: #37290

Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 xiaocai2333 deleted the refine_text_match branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot