Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.5]The expression supports filling elements through templates #37280

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36672

master pr: #37033

milvus-proto pr: milvus-io/milvus-proto#332

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/test sig/testing labels Oct 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Oct 30, 2024
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 78.85196% with 140 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (12fb9d6) to head (7281372).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/parser/planparserv2/utils.go 68.45% 52 Missing and 1 partial ⚠️
internal/parser/planparserv2/parser_visitor.go 78.28% 27 Missing and 21 partials ⚠️
...ernal/parser/planparserv2/fill_expression_value.go 87.97% 17 Missing and 5 partials ⚠️
...lanparserv2/convert_field_data_to_generic_value.go 81.03% 8 Missing and 3 partials ⚠️
internal/parser/planparserv2/node_ret.go 62.50% 2 Missing and 1 partial ⚠️
internal/parser/planparserv2/plan_parser_v2.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37280      +/-   ##
==========================================
- Coverage   83.15%   80.84%   -2.32%     
==========================================
  Files        1029     1321     +292     
  Lines      157316   183133   +25817     
==========================================
+ Hits       130822   148057   +17235     
- Misses      21327    29873    +8546     
- Partials     5167     5203      +36     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.95% <ø> (∅)
Go 83.11% <78.85%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
internal/parser/planparserv2/show_visitor.go 93.52% <100.00%> (+3.08%) ⬆️
internal/proxy/task.go 86.98% <ø> (ø)
internal/proxy/task_delete.go 92.43% <100.00%> (ø)
internal/proxy/task_query.go 80.71% <100.00%> (ø)
internal/proxy/task_search.go 76.20% <100.00%> (+0.24%) ⬆️
internal/parser/planparserv2/node_ret.go 75.00% <62.50%> (-5.00%) ⬇️
internal/parser/planparserv2/plan_parser_v2.go 87.19% <75.00%> (-1.08%) ⬇️
...lanparserv2/convert_field_data_to_generic_value.go 81.03% <81.03%> (ø)
...ernal/parser/planparserv2/fill_expression_value.go 87.97% <87.97%> (ø)
internal/parser/planparserv2/parser_visitor.go 85.95% <78.28%> (-2.56%) ⬇️
... and 1 more

... and 321 files with indirect coverage changes

@xiaocai2333 xiaocai2333 force-pushed the template_expression_parse-5 branch from 6f0ca26 to c1a0cb5 Compare October 30, 2024 03:18
Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@zhengbuqian
Copy link
Collaborator

/lgtm

Copy link
Contributor

mergify bot commented Oct 30, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the template_expression_parse-5 branch from c1a0cb5 to 7281372 Compare October 31, 2024 03:33
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 31, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Oct 31, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 31, 2024
@sre-ci-robot sre-ci-robot merged commit c1be102 into milvus-io:2.5 Oct 31, 2024
18 of 20 checks passed
@xiaocai2333 xiaocai2333 deleted the template_expression_parse-5 branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants