Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Separate L0 and Mix trigger interval #37190

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fix: Separate L0 and Mix trigger interval #37190

merged 6 commits into from
Nov 12, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37108

  • Add MixCompactionTriggerInterval, default 60s
  • Add L0CompactionTriggerInterval, default 10s
  • Export Single related compaction configs
  • Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing test/integration integration test labels Oct 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (61a5b15) to head (08eb33e).
Report is 9 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (61a5b15) and HEAD (08eb33e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (61a5b15) HEAD (08eb33e)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37190       +/-   ##
===========================================
- Coverage   80.59%   68.13%   -12.47%     
===========================================
  Files        1356      290     -1066     
  Lines      190010    25395   -164615     
===========================================
- Hits       153148    17302   -135846     
+ Misses      31460     8093    -23367     
+ Partials     5402        0     -5402
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (ø)
Go ∅ <ø> (∅)

see 1066 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

rerun ut

4 similar comments
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun go-sdk

@XuanYang-cn XuanYang-cn force-pushed the ease-delete-size-mix-compaction branch from c80724e to 1456295 Compare October 31, 2024 02:58
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Oct 31, 2024
@XuanYang-cn
fix: Saperate L0 and Mix trigger interval
889e2d3 
See also: milvus-io#37108
pr: milvus-io#37190

- Add MixCompactionTriggerInterval, default 60s
- Add L0CompactionTriggerInterval, default 10s
- Export Single related compaction configs
- Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this pull request Oct 31, 2024
Merged
@XuanYang-cn XuanYang-cn force-pushed the ease-delete-size-mix-compaction branch from 1456295 to 6e68675 Compare October 31, 2024 03:04
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Oct 31, 2024
@XuanYang-cn
fix: Saperate L0 and Mix trigger interval
2490e6b 
See also: milvus-io#37108
pr: milvus-io#37190

- Add MixCompactionTriggerInterval, default 60s
- Add L0CompactionTriggerInterval, default 10s
- Export Single related compaction configs
- Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

Signed-off-by: yangxuan <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Oct 31, 2024
@XuanYang-cn
fix: [cp25]Saperate L0 and Mix trigger interval
0abdc42 
See also: milvus-io#37108
pr: milvus-io#37190

- Add MixCompactionTriggerInterval, default 60s
- Add L0CompactionTriggerInterval, default 10s
- Export Single related compaction configs
- Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this pull request Oct 31, 2024
Closed
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 11, 2024
@XuanYang-cn XuanYang-cn changed the title fix: Saperate L0 and Mix trigger interval fix: Separate L0 and Mix trigger interval Nov 11, 2024
@mergify mergify bot removed the ci-passed label Nov 11, 2024
congqixia
congqixia approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@XuanYang-cn
fix: Saperate L0 and Mix trigger interval
aca666f 
See also: milvus-io#37108

- Add MixCompactionTriggerInterval, default 60s
- Add L0CompactionTriggerInterval, default 10s
- Export Single related compaction configs
- Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
enhance according to the comment
78b1367 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
regen milvus yaml
46df42d 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
Reset mixcompaction interval
4d2bc71 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
add back the knowhere configs
b91320c 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn force-pushed the ease-delete-size-mix-compaction branch from 0736052 to b91320c Compare November 11, 2024 06:44
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Nov 11, 2024
congqixia
congqixia approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a45a288 into milvus-io:master Nov 12, 2024
18 of 20 checks passed
@XuanYang-cn XuanYang-cn deleted the ease-delete-size-mix-compaction branch November 12, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuanYang-cn @sre-ci-robot @congqixia