Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: all op(Null) is false in expr #35527

Merged
merged 4 commits into from
Oct 17, 2024

fix comment

37ce45b
Select commit
Loading
Failed to load commit list.
Merged

enhance: all op(Null) is false in expr #35527

fix comment
37ce45b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 15, 2024 in 1s

81.45% (target 77.00%)

View this Pull Request on Codecov

81.45% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 67.55556% with 219 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (1bd3228) to head (37ce45b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/CompareExpr.cpp 34.44% 59 Missing ⚠️
internal/core/src/exec/expression/Expr.h 46.15% 49 Missing ⚠️
internal/core/src/segcore/Utils.cpp 44.44% 35 Missing ⚠️
...src/exec/expression/BinaryArithOpEvalRangeExpr.cpp 80.95% 12 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 10 Missing ⚠️
internal/core/src/exec/expression/CompareExpr.h 52.63% 9 Missing ⚠️
internal/core/src/exec/expression/TermExpr.cpp 82.60% 8 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 92.30% 5 Missing ⚠️
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 86.66% 4 Missing ⚠️
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 93.44% 4 Missing ⚠️
... and 10 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35527      +/-   ##
==========================================
+ Coverage   72.50%   81.45%   +8.94%     
==========================================
  Files        1308     1308              
  Lines      156203   156659     +456     
==========================================
+ Hits       113255   127602   +14347     
+ Misses      37817    23941   -13876     
+ Partials     5131     5116      -15
Files with missing lines Coverage Δ
internal/core/src/common/FieldData.cpp 73.91% <100.00%> (+73.91%) ⬆️
internal/core/src/common/Vector.h 100.00% <100.00%> (+93.33%) ⬆️
...ternal/core/src/exec/expression/AlwaysTrueExpr.cpp 85.71% <100.00%> (+85.71%) ⬆️
...e/src/exec/expression/BinaryArithOpEvalRangeExpr.h 100.00% <100.00%> (+100.00%) ⬆️
internal/core/src/exec/expression/ExistsExpr.cpp 86.66% <100.00%> (+86.66%) ⬆️
...rnal/core/src/exec/expression/LogicalUnaryExpr.cpp 100.00% <100.00%> (+100.00%) ⬆️
internal/core/src/exec/operator/FilterBitsNode.cpp 96.07% <100.00%> (+96.07%) ⬆️
internal/core/src/index/BitmapIndex.h 55.55% <ø> (+55.55%) ⬆️
internal/core/src/index/ScalarIndex.h 27.77% <ø> (+25.00%) ⬆️
internal/core/src/index/ScalarIndexSort.h 42.85% <ø> (ø)
... and 23 more

... and 212 files with indirect coverage changes

View more details on Codecov