Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Improve bitset performance for AVX512 #35480

Merged

Conversation

alexanderguzhva
Copy link
Contributor

@alexanderguzhva alexanderguzhva commented Aug 14, 2024

see #35478
pr: #35479

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 14, 2024
Copy link
Contributor

mergify bot commented Aug 14, 2024

@alexanderguzhva Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the dco-passed DCO check passed. label Aug 14, 2024
Copy link
Contributor

mergify bot commented Aug 14, 2024

@alexanderguzhva

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@alexanderguzhva alexanderguzhva changed the title Improve bitset performance for AVX512 enhance: [2.4] Improve bitset performance for AVX512 Aug 14, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr do-not-merge/invalid-pr-format labels Aug 14, 2024
@alexanderguzhva
Copy link
Contributor Author

@zhagnlu, @xiaofan-luan would you please accept this one as well? :) Thanks

@xiaofan-luan
Copy link
Collaborator

there seems to be an UT error. rerun the test

@mergify mergify bot added the ci-passed label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 204 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (57d4bcb) to head (22366e1).
Report is 10 commits behind head on 2.4.

Files Patch % Lines
.../core/src/bitset/detail/platform/x86/avx512-impl.h 0.00% 204 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35480      +/-   ##
==========================================
- Coverage   81.21%   81.12%   -0.09%     
==========================================
  Files        1056     1051       -5     
  Lines      138010   138546     +536     
==========================================
+ Hits       112088   112399     +311     
- Misses      21694    21925     +231     
+ Partials     4228     4222       -6     
Files Coverage Δ
.../core/src/bitset/detail/platform/x86/avx512-impl.h 0.00% <0.00%> (ø)

... and 230 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit 8ddc3fd into milvus-io:2.4 Aug 16, 2024
13 of 15 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants