Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: support bitmap mmap #35399

Merged
merged 1 commit into from
Aug 27, 2024
Merged

enhance: support bitmap mmap #35399

merged 1 commit into from
Aug 27, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Aug 9, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch 2 times, most recently from fdca4ed to 9d63c1e Compare August 16, 2024 09:45
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 16, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 50 lines in your changes missing coverage. Please review.

Project coverage is 81.32%. Comparing base (0e7877d) to head (29bb1e2).
Report is 9 commits behind head on master.

Files Patch % Lines
internal/core/src/index/BitmapIndex.cpp 75.50% 49 Missing ⚠️
pkg/util/indexparamcheck/index_type.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35399      +/-   ##
==========================================
+ Coverage   72.37%   81.32%   +8.95%     
==========================================
  Files        1237     1237              
  Lines      147726   147946     +220     
==========================================
+ Hits       106912   120316   +13404     
+ Misses      36054    22862   -13192     
- Partials     4760     4768       +8
Files Coverage Δ
internal/core/src/common/Json.h 67.90% <ø> (+8.64%) ⬆️
internal/core/src/index/BitmapIndex.h 55.55% <100.00%> (+55.55%) ⬆️
internal/core/src/index/HybridScalarIndex.cpp 78.65% <100.00%> (+78.65%) ⬆️
internal/core/src/index/Index.h 100.00% <100.00%> (+18.75%) ⬆️
internal/core/src/index/InvertedIndexTantivy.cpp 91.38% <100.00%> (+91.38%) ⬆️
internal/core/src/index/InvertedIndexTantivy.h 50.00% <100.00%> (ø)
internal/core/src/index/ScalarIndex.h 27.77% <100.00%> (+24.92%) ⬆️
internal/core/src/index/ScalarIndexSort.cpp 66.81% <100.00%> (+66.81%) ⬆️
internal/core/src/index/StringIndex.h 88.88% <100.00%> (+88.88%) ⬆️
internal/core/src/index/StringIndexMarisa.cpp 64.72% <100.00%> (+64.72%) ⬆️
... and 3 more

... and 230 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Aug 16, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Aug 16, 2024
@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch from 9d63c1e to a243839 Compare August 19, 2024 02:43
@mergify mergify bot added ci-passed and removed ci-passed labels Aug 19, 2024
@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch from a243839 to 6f25a34 Compare August 20, 2024 06:47
@mergify mergify bot removed the ci-passed label Aug 20, 2024
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Aug 21, 2024

rerun ut

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Aug 21, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch from 6f25a34 to 510cb9f Compare August 22, 2024 07:27
@mergify mergify bot added the ci-passed label Aug 22, 2024
czs007
czs007 reviewed Aug 25, 2024
View reviewed changes
pkg/util/indexparamcheck/index_type.go Outdated
indexType == IndexSparseWand
indexType == IndexSparseWand ||
indexType == IndexBitmap ||
indexType == IndexHybrid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HybridINdex is not Vector Index

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@czs007
Copy link
Collaborator

czs007 commented Aug 26, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch from 510cb9f to c5207ad Compare August 26, 2024 06:52
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 26, 2024
@mergify mergify bot removed the ci-passed label Aug 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 26, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch 2 times, most recently from a576233 to f9585f1 Compare August 26, 2024 08:44
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Aug 26, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch from f9585f1 to 2f25a48 Compare August 26, 2024 11:34
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Aug 27, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the support_bitmap_mmap branch from 2f25a48 to 29bb1e2 Compare August 27, 2024 06:13
@mergify mergify bot added the ci-passed label Aug 27, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 27, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4d2f96c into milvus-io:master Aug 27, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhagnlu @czs007 @sre-ci-robot