Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ppc64le-support #35319

Closed
wants to merge 12 commits into from
Closed

feat: ppc64le-support #35319

wants to merge 12 commits into from

Conversation

sumitd2
Copy link

@sumitd2 sumitd2 commented Aug 6, 2024

issue: #29566

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Aug 6, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sumitd2
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing labels Aug 6, 2024
Signed-off-by: Sumit Dubey <[email protected]>
Copy link
Contributor

mergify bot commented Aug 6, 2024

@sumitd2 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/feature Issues related to feature request from users dco-passed DCO check passed. labels Aug 6, 2024
Copy link
Contributor

mergify bot commented Aug 6, 2024

@sumitd2 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@sumitd2
Copy link
Author

sumitd2 commented Aug 6, 2024

@xiaofan-luan master is no longer building on power, error is

ERROR: Conflict in opentelemetry-cpp/1.8.1.1@milvus/dev:
    'opentelemetry-cpp/1.8.1.1@milvus/dev' requires 'grpc/1.50.1' while 'google-cloud-cpp/2.5.0@milvus/dev' requires 'grpc/1.54.3@milvus/dev'.
    To fix this conflict you need to override the package 'grpc' in your root package.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (7859faf) to head (440e0c3).
Report is 755 commits behind head on master.

Current head 440e0c3 differs from pull request most recent head 19a5c8d

Please upload reports for the commit 19a5c8d to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35319      +/-   ##
==========================================
- Coverage   72.62%   72.39%   -0.23%     
==========================================
  Files        1266     1215      -51     
  Lines      150757   143822    -6935     
==========================================
- Hits       109485   104124    -5361     
+ Misses      36395    35268    -1127     
+ Partials     4877     4430     -447     
Files with missing lines Coverage Δ
internal/core/src/index/Utils.h 0.00% <ø> (ø)

... and 580 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Aug 8, 2024

@sumitd2 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Aug 8, 2024
@sumitd2 sumitd2 closed this Dec 13, 2024
@sumitd2 sumitd2 deleted the ppc64le-support branch December 13, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test do-not-merge/work-in-progress Don't merge even CI passed. kind/feature Issues related to feature request from users needs-dco DCO is missing in this pull request. sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants