Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix functional-notation casting in AssertInfo #35236

Closed
wants to merge 1 commit into from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Aug 2, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.20%. Comparing base (b4d0f4d) to head (87116aa).
Report is 27 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35236      +/-   ##
==========================================
- Coverage   81.53%   72.20%   -9.33%     
==========================================
  Files        1192     1188       -4     
  Lines      141755   142499     +744     
==========================================
- Hits       115574   102888   -12686     
- Misses      21861    35252   +13391     
- Partials     4320     4359      +39     
Files Coverage Δ
internal/core/src/common/EasyAssert.h 47.05% <ø> (-36.28%) ⬇️

... and 321 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Aug 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants