Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [skip e2e] effective way to use cache #35232

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Aug 2, 2024

issue: #34876
#35109

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 2, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/feature Issues related to feature request from users labels Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (f8444b9) to head (3783e16).
Report is 20 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35232      +/-   ##
==========================================
+ Coverage   80.21%   81.13%   +0.91%     
==========================================
  Files        1052     1052              
  Lines      136848   136856       +8     
==========================================
+ Hits       109776   111041    +1265     
+ Misses      22858    21594    -1264     
- Partials     4214     4221       +7     

see 102 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yellow-shine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yellow-shine yellow-shine added the kind/enhancement Issues or changes related to enhancement label Aug 6, 2024
@mergify mergify bot added the ci-passed label Aug 6, 2024
@sre-ci-robot sre-ci-robot merged commit 94bb687 into milvus-io:2.4 Aug 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/feature Issues related to feature request from users lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants