-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [skip e2e] effective way to use cache #35232
Conversation
@yellow-shine Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
@yellow-shine Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
…-io#35109) See also milvus-io#34483 Signed-off-by: Yellow Shine <[email protected]>
2f636af
to
3783e16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #35232 +/- ##
==========================================
+ Coverage 80.21% 81.13% +0.91%
==========================================
Files 1052 1052
Lines 136848 136856 +8
==========================================
+ Hits 109776 111041 +1265
+ Misses 22858 21594 -1264
- Partials 4214 4221 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, yellow-shine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #34876
#35109