Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add log for partition stats( #30376) #35219

Merged

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Aug 2, 2024

related: #30376

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 2, 2024
@MrPresent-Han MrPresent-Han changed the title enhance: add log for partition stats(#35184) enhance: add log for partition stats( #30376) Aug 2, 2024
@mergify mergify bot added the ci-passed label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (a642a26) to head (bad763f).
Report is 21 commits behind head on master.

Files Patch % Lines
internal/querynodev2/delegator/delegator.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #35219       +/-   ##
===========================================
- Coverage   81.54%   70.52%   -11.02%     
===========================================
  Files        1188     1193        +5     
  Lines      142311   142056      -255     
===========================================
- Hits       116047   100186    -15861     
- Misses      21935    37523    +15588     
- Partials     4329     4347       +18     
Files Coverage Δ
internal/querycoordv2/checkers/leader_checker.go 96.37% <100.00%> (+0.22%) ⬆️
internal/querycoordv2/meta/target_manager.go 88.80% <100.00%> (+0.20%) ⬆️
internal/querynodev2/delegator/delegator.go 87.02% <87.50%> (+0.15%) ⬆️

... and 317 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3faef63 into milvus-io:master Aug 2, 2024
14 of 15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 2, 2024
related: #30376
pr: #35219

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
related:  milvus-io#30376

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants