Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove timestamp_filter after retrieve #35207

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Aug 2, 2024

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

@zhagnlu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@zhagnlu zhagnlu force-pushed the remove_retrieve_ts branch from 2939a4d to b13aab9 Compare August 2, 2024 02:50
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 2, 2024
@mergify mergify bot added the ci-passed label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (b4d0f4d) to head (b13aab9).
Report is 15 commits behind head on master.

Current head b13aab9 differs from pull request most recent head 033d58c

Please upload reports for the commit 033d58c to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35207      +/-   ##
==========================================
- Coverage   81.53%   80.05%   -1.48%     
==========================================
  Files        1192     1188       -4     
  Lines      141755   142329     +574     
==========================================
- Hits       115574   113937    -1637     
- Misses      21861    24053    +2192     
- Partials     4320     4339      +19     
Files Coverage Δ
internal/core/src/exec/expression/TermExpr.cpp 81.16% <100.00%> (-2.28%) ⬇️
...nal/core/src/query/generated/ExecPlanNodeVisitor.h 80.76% <ø> (-6.74%) ⬇️
...ternal/core/src/query/visitors/ExecExprVisitor.cpp 0.10% <ø> (-0.01%) ⬇️
...al/core/src/query/visitors/ExecPlanNodeVisitor.cpp 99.32% <100.00%> (-0.68%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.h 50.63% <ø> (-33.99%) ⬇️
internal/core/src/segcore/SegmentInterface.h 91.66% <ø> (-4.49%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.h 59.09% <ø> (-22.73%) ⬇️

... and 270 files with indirect coverage changes

@zhagnlu zhagnlu force-pushed the remove_retrieve_ts branch from b13aab9 to 033d58c Compare August 2, 2024 08:06
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Aug 2, 2024
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Aug 2, 2024

rerun ut

@sre-ci-robot sre-ci-robot merged commit 16dd53e into milvus-io:master Aug 2, 2024
11 of 13 checks passed
sre-ci-robot added a commit that referenced this pull request Aug 2, 2024
@mergify mergify bot added the ci-passed label Aug 2, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants