Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Support proxy/delegator qn client pooling #35195

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Aug 1, 2024

Cherry pick from master
pr: #35194
See also #35196
Add param item for proxy/delegator query node client pooling and implement pooling logic

Add param item for proxy/delegator query node client pooling and
implement pooling logic

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot requested a review from aoiasd August 1, 2024 11:51
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from bigsheeper August 1, 2024 11:51
@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Aug 1, 2024
Copy link
Contributor

mergify bot commented Aug 1, 2024

@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Aug 1, 2024
Copy link
Contributor

mergify bot commented Aug 1, 2024

@congqixia Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Aug 1, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Aug 1, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 86.58537% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (f718410) to head (6480cf4).
Report is 3 commits behind head on 2.4.

Files Patch % Lines
internal/querynodev2/cluster/worker.go 82.92% 4 Missing and 3 partials ⚠️
internal/proxy/shard_client.go 83.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35195      +/-   ##
==========================================
- Coverage   81.13%   72.18%   -8.95%     
==========================================
  Files        1052     1052              
  Lines      136740   136806      +66     
==========================================
- Hits       110942    98752   -12190     
- Misses      21586    33867   +12281     
+ Partials     4212     4187      -25     
Files Coverage Δ
internal/querynodev2/server.go 76.78% <100.00%> (+0.62%) ⬆️
pkg/util/paramtable/component_param.go 98.55% <100.00%> (+<0.01%) ⬆️
internal/proxy/shard_client.go 80.30% <83.33%> (-10.61%) ⬇️
internal/querynodev2/cluster/worker.go 85.71% <82.92%> (-3.48%) ⬇️

... and 236 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit f8444b9 into milvus-io:2.4 Aug 2, 2024
13 of 15 checks passed
@congqixia congqixia deleted the cp24/35194 branch August 12, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants