Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: querynode hang when failing to allocate disk space for mmap(#35184) #35187

Merged

Conversation

MrPresent-Han
Copy link
Contributor

related: #35184

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Aug 1, 2024
@mergify mergify bot added the ci-passed label Aug 1, 2024
@MrPresent-Han MrPresent-Han force-pushed the fix-querynode-hang-master branch from e4c8325 to e96d087 Compare August 1, 2024 13:23
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.40%. Comparing base (1d49358) to head (d7a8ef6).
Report is 12 commits behind head on master.

Files Patch % Lines
internal/core/src/storage/ChunkCache.cpp 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35187      +/-   ##
==========================================
- Coverage   72.41%   70.40%   -2.01%     
==========================================
  Files        1226     1221       -5     
  Lines      144651   145288     +637     
==========================================
- Hits       104751   102296    -2455     
- Misses      35423    38517    +3094     
+ Partials     4477     4475       -2     
Files Coverage Δ
internal/core/src/storage/ChunkCache.cpp 0.00% <0.00%> (ø)

... and 269 files with indirect coverage changes

@mergify mergify bot removed the ci-passed label Aug 1, 2024
@MrPresent-Han MrPresent-Han force-pushed the fix-querynode-hang-master branch from e96d087 to 6928dc4 Compare August 2, 2024 04:44
sre-ci-robot pushed a commit that referenced this pull request Aug 2, 2024
…) (#35189)

related: #35184
pr: #35187

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
@MrPresent-Han MrPresent-Han force-pushed the fix-querynode-hang-master branch 2 times, most recently from f324c2b to 7ddb947 Compare August 16, 2024 02:50
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Aug 16, 2024
@MrPresent-Han MrPresent-Han force-pushed the fix-querynode-hang-master branch from 7ddb947 to d7a8ef6 Compare August 19, 2024 02:47
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 337e065 into milvus-io:master Aug 19, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants