Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support auto index for array #35095

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented Jul 30, 2024

/kind branch-feature
pr: #34450

Signed-off-by: longjiquan <[email protected]>
Co-authored-by: Zhagnlu <[email protected]>
@sre-ci-robot sre-ci-robot added kind/branch-feature size/M Denotes a PR that changes 30-99 lines. labels Jul 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 30, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Jul 30, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (cc188fb) to head (ba46c8e).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35095      +/-   ##
==========================================
- Coverage   81.10%   81.10%   -0.01%     
==========================================
  Files        1051     1051              
  Lines      136692   136726      +34     
==========================================
+ Hits       110870   110889      +19     
- Misses      21620    21633      +13     
- Partials     4202     4204       +2     
Files Coverage Δ
internal/proxy/accesslog/info/grpc_info.go 96.47% <ø> (ø)
pkg/util/paramtable/component_param.go 98.53% <ø> (ø)
pkg/util/typeutil/schema.go 85.59% <0.00%> (-0.15%) ⬇️
internal/proxy/task_index.go 84.35% <77.77%> (+0.04%) ⬆️

... and 28 files with indirect coverage changes

@zhagnlu
Copy link
Contributor

zhagnlu commented Jul 30, 2024

/lgtm

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 30, 2024
@sre-ci-robot sre-ci-robot merged commit 86edca8 into milvus-io:2.4 Jul 30, 2024
10 of 15 checks passed
@longjiquan longjiquan deleted the fix-array-autoindex branch July 30, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants